diff options
| author | Maxim Cournoyer <maxim.cournoyer@gmail.com> | 2019-04-03 00:09:20 -0400 |
|---|---|---|
| committer | Maxim Cournoyer <maxim.cournoyer@gmail.com> | 2019-04-18 00:04:26 -0400 |
| commit | 6bbb37a545912c6bb2513ee08587ee4fe39cc330 (patch) | |
| tree | 2fd52cb74d588c781fcb294dd8bd5024bf01ce96 /guix | |
| parent | db65a4fd914be10f9170cb8ad049e15eefefd5a9 (diff) | |
build-system/python: Move the check phase after the install phase.
A reproducibility problem was discovered while packaging python-pygithub where
the bytecode produced by running the tests would interfere with the result of
the install phase byte compilation. Moving the check phase after the install
phase solves the problem.
* guix/build/python-build-system.scm (%standard-phases): Add comment, move
the check phase after the install phase.
Diffstat (limited to 'guix')
| -rw-r--r-- | guix/build/python-build-system.scm | 13 |
1 files changed, 9 insertions, 4 deletions
diff --git a/guix/build/python-build-system.scm b/guix/build/python-build-system.scm index 73b554c766..7c00306b3e 100644 --- a/guix/build/python-build-system.scm +++ b/guix/build/python-build-system.scm @@ -250,16 +250,21 @@ installed with setuptools." #t) (define %standard-phases - ;; 'configure' phase is not needed. + ;; The build phase only builds C extensions and copies the Python sources, + ;; while the install phase byte-compiles and copies them to the prefix + ;; directory. The tests are run after the install phase because otherwise + ;; the cached .pyc generated during the tests execution seem to interfere + ;; with the byte compilation of the install phase. (modify-phases gnu:%standard-phases (add-after 'unpack 'ensure-no-mtimes-pre-1980 ensure-no-mtimes-pre-1980) (add-after 'ensure-no-mtimes-pre-1980 'enable-bytecode-determinism enable-bytecode-determinism) (delete 'bootstrap) - (delete 'configure) - (replace 'install install) - (replace 'check check) + (delete 'configure) ;not needed (replace 'build build) + (delete 'check) ;moved after the install phase + (replace 'install install) + (add-after 'install 'check check) (add-after 'install 'wrap wrap) (add-before 'strip 'rename-pth-file rename-pth-file))) |