From c24f1f1614a2ba7ff7c5828a8753f82c9792349a Mon Sep 17 00:00:00 2001 From: Efraim Flashner Date: Mon, 19 Mar 2018 21:33:29 +0200 Subject: gnu: patchelf: Use 'target-arm32?' for armhf-linux case. * gnu/packages/elf.scm (patchelf)[inputs]: Replace armhf-linux detection logic with 'target-arm32?' macro. [arguments]: Same. --- gnu/packages/elf.scm | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) (limited to 'gnu/packages/elf.scm') diff --git a/gnu/packages/elf.scm b/gnu/packages/elf.scm index 8fb568b841..8329637da3 100644 --- a/gnu/packages/elf.scm +++ b/gnu/packages/elf.scm @@ -22,6 +22,7 @@ ;;; along with GNU Guix. If not, see . (define-module (gnu packages elf) + #:use-module (guix utils) #:use-module (guix packages) #:use-module (guix download) #:use-module (guix build-system gnu) @@ -121,12 +122,12 @@ Executable and Linkable Format (@dfn{ELF}). This includes @command{ld}, ;; patch makes significant changes to the algorithm, possibly ;; introducing bugs. So, we apply the patch only on ARM systems. (inputs - (if (string-prefix? "arm" (or (%current-target-system) (%current-system))) + (if (target-arm32?) `(("patch/rework-for-arm" ,(search-patch "patchelf-rework-for-arm.patch"))) '())) (arguments - (if (string-prefix? "arm" (or (%current-target-system) (%current-system))) + (if (target-arm32?) `(#:phases (alist-cons-after 'unpack 'patch/rework-for-arm (lambda* (#:key inputs #:allow-other-keys) -- cgit v1.2.3 From c1d1cd817c7ab8d99e962e286c207943765a8e8f Mon Sep 17 00:00:00 2001 From: Efraim Flashner Date: Mon, 19 Mar 2018 21:43:09 +0200 Subject: gnu: patchelf: Update argument phase. * gnu/packages/elf.scm (patchelf)[arguments]: Use 'modify-phases' syntax. Replace 'system*' with 'invoke'. --- gnu/packages/elf.scm | 14 ++++++-------- 1 file changed, 6 insertions(+), 8 deletions(-) (limited to 'gnu/packages/elf.scm') diff --git a/gnu/packages/elf.scm b/gnu/packages/elf.scm index 8329637da3..350cd2a3c1 100644 --- a/gnu/packages/elf.scm +++ b/gnu/packages/elf.scm @@ -128,14 +128,12 @@ Executable and Linkable Format (@dfn{ELF}). This includes @command{ld}, '())) (arguments (if (target-arm32?) - `(#:phases (alist-cons-after - 'unpack 'patch/rework-for-arm - (lambda* (#:key inputs #:allow-other-keys) - (let ((patch-file - (assoc-ref inputs "patch/rework-for-arm"))) - (zero? (system* "patch" "--force" "-p1" - "--input" patch-file)))) - %standard-phases)) + `(#:phases + (modify-phases %standard-phases + (add-after 'unpack 'patch/rework-for-arm + (lambda* (#:key inputs #:allow-other-keys) + (let ((patch-file (assoc-ref inputs "patch/rework-for-arm"))) + (invoke "patch" "--force" "-p1" "--input" patch-file)))))) '())) (home-page "https://nixos.org/patchelf.html") -- cgit v1.2.3 From 05666fb8dbcc7cb482ba1e4caa0fba333a738621 Mon Sep 17 00:00:00 2001 From: Efraim Flashner Date: Mon, 19 Mar 2018 21:44:50 +0200 Subject: patchelf: Use 'https' for source uri. * gnu/packages/elf.scm (patchelf)[source]: Use 'https' for source uri. --- gnu/packages/elf.scm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'gnu/packages/elf.scm') diff --git a/gnu/packages/elf.scm b/gnu/packages/elf.scm index 350cd2a3c1..08d92532fa 100644 --- a/gnu/packages/elf.scm +++ b/gnu/packages/elf.scm @@ -109,7 +109,7 @@ Executable and Linkable Format (@dfn{ELF}). This includes @command{ld}, (source (origin (method url-fetch) (uri (string-append - "http://nixos.org/releases/patchelf/patchelf-" + "https://nixos.org/releases/patchelf/patchelf-" version "/patchelf-" version ".tar.bz2")) (sha256 -- cgit v1.2.3 From b1d096f869ed53b84486855d73c7e9070fdf3ae2 Mon Sep 17 00:00:00 2001 From: Marius Bakke Date: Mon, 19 Mar 2018 23:46:25 +0100 Subject: Revert "gnu: patchelf: Update argument phase." It causes too many rebuilds this late in the 'staging' cycle. This reverts commit c1d1cd817c7ab8d99e962e286c207943765a8e8f. --- gnu/packages/elf.scm | 14 ++++++++------ 1 file changed, 8 insertions(+), 6 deletions(-) (limited to 'gnu/packages/elf.scm') diff --git a/gnu/packages/elf.scm b/gnu/packages/elf.scm index 08d92532fa..253547e70f 100644 --- a/gnu/packages/elf.scm +++ b/gnu/packages/elf.scm @@ -128,12 +128,14 @@ Executable and Linkable Format (@dfn{ELF}). This includes @command{ld}, '())) (arguments (if (target-arm32?) - `(#:phases - (modify-phases %standard-phases - (add-after 'unpack 'patch/rework-for-arm - (lambda* (#:key inputs #:allow-other-keys) - (let ((patch-file (assoc-ref inputs "patch/rework-for-arm"))) - (invoke "patch" "--force" "-p1" "--input" patch-file)))))) + `(#:phases (alist-cons-after + 'unpack 'patch/rework-for-arm + (lambda* (#:key inputs #:allow-other-keys) + (let ((patch-file + (assoc-ref inputs "patch/rework-for-arm"))) + (zero? (system* "patch" "--force" "-p1" + "--input" patch-file)))) + %standard-phases)) '())) (home-page "https://nixos.org/patchelf.html") -- cgit v1.2.3 From dbc75dadb54dd0e6b3a125949c26aadfa3bff4ca Mon Sep 17 00:00:00 2001 From: Marius Bakke Date: Tue, 20 Mar 2018 00:20:59 +0100 Subject: Revert "Revert "gnu: patchelf: Update argument phase."" This change only affects armhf, which doesn't use PatchELF. My bad! This reverts commit b1d096f869ed53b84486855d73c7e9070fdf3ae2. --- gnu/packages/elf.scm | 14 ++++++-------- 1 file changed, 6 insertions(+), 8 deletions(-) (limited to 'gnu/packages/elf.scm') diff --git a/gnu/packages/elf.scm b/gnu/packages/elf.scm index 253547e70f..08d92532fa 100644 --- a/gnu/packages/elf.scm +++ b/gnu/packages/elf.scm @@ -128,14 +128,12 @@ Executable and Linkable Format (@dfn{ELF}). This includes @command{ld}, '())) (arguments (if (target-arm32?) - `(#:phases (alist-cons-after - 'unpack 'patch/rework-for-arm - (lambda* (#:key inputs #:allow-other-keys) - (let ((patch-file - (assoc-ref inputs "patch/rework-for-arm"))) - (zero? (system* "patch" "--force" "-p1" - "--input" patch-file)))) - %standard-phases)) + `(#:phases + (modify-phases %standard-phases + (add-after 'unpack 'patch/rework-for-arm + (lambda* (#:key inputs #:allow-other-keys) + (let ((patch-file (assoc-ref inputs "patch/rework-for-arm"))) + (invoke "patch" "--force" "-p1" "--input" patch-file)))))) '())) (home-page "https://nixos.org/patchelf.html") -- cgit v1.2.3