diff options
author | Ludovic Courtès <ludo@gnu.org> | 2017-12-06 09:07:28 +0100 |
---|---|---|
committer | Ludovic Courtès <ludo@gnu.org> | 2017-12-06 09:07:28 +0100 |
commit | 609d126e86ea7a05ab7e758fa3fd000ced005f49 (patch) | |
tree | 9bc27e832508ae30cb75016d2d1ad789ce988c15 /guix | |
parent | f0eb57b736f6fae67acbaad66a1b5e18fdfc10a0 (diff) |
Revert "packages: 'package-grafts' trims native inputs."
This reverts commit 91c9b5d016ac8bed127557d378c70fbc56cec0e5
following the concerns raised by Mark, Ben, and Tobias:
<https://lists.gnu.org/archive/html/guix-devel/2017-12/msg00081.html>.
Diffstat (limited to 'guix')
-rw-r--r-- | guix/packages.scm | 53 |
1 files changed, 22 insertions, 31 deletions
diff --git a/guix/packages.scm b/guix/packages.scm index 490ec86906..c6d3b811f2 100644 --- a/guix/packages.scm +++ b/guix/packages.scm @@ -1004,21 +1004,7 @@ dependencies; otherwise, restrict to target dependencies." (if (bag-target bag) '() (bag-host-inputs bag)))) - (lambda (bag) - (if (bag-target bag) - (bag-host-inputs bag) - - ;; XXX: Currently libc wrongfully ends up in 'build-inputs', - ;; even tough it's something that's still referenced at run time - ;; and thus conceptually a 'host-inputs'. Because of that, we - ;; re-add it here. - (if (assoc-ref (bag-host-inputs bag) "libc") - (bag-host-inputs bag) - (append (let ((libc (assoc-ref (bag-build-inputs bag) - "libc"))) - (or (and libc `(("libc" ,@libc))) - '())) - (bag-host-inputs bag))))))) + bag-host-inputs)) (define nodes (match (bag-direct-inputs* bag) @@ -1052,28 +1038,33 @@ to (see 'graft-derivation'.)" (define system (bag-system bag)) (define target (bag-target bag)) - (define (grafts package->graft) - (fold-bag-dependencies (lambda (package grafts) - (match (package->graft package) - (#f grafts) - (graft (cons graft grafts)))) - '() - bag - - ;; Grafts that apply to native inputs do not matter - ;; since, by definition, native inputs are not - ;; referred to at run time. Thus, ignore - ;; 'native-inputs' and focus on the others. - #:native? #f)) + (define native-grafts + (let ((->graft (input-graft store system))) + (fold-bag-dependencies (lambda (package grafts) + (match (->graft package) + (#f grafts) + (graft (cons graft grafts)))) + '() + bag))) + + (define target-grafts + (if target + (let ((->graft (input-cross-graft store target system))) + (fold-bag-dependencies (lambda (package grafts) + (match (->graft package) + (#f grafts) + (graft (cons graft grafts)))) + '() + bag + #:native? #f)) + '())) ;; We can end up with several identical grafts if we stumble upon packages ;; that are not 'eq?' but map to the same derivation (this can happen when ;; using things like 'package-with-explicit-inputs'.) Hence the ;; 'delete-duplicates' call. (delete-duplicates - (if target - (grafts (input-cross-graft store target system)) - (grafts (input-graft store system))))) + (append native-grafts target-grafts))) (define* (package-grafts store package #:optional (system (%current-system)) |