Merge pull request #5 from icebaker/ib-tools

Adding support for Spec 1.0.0: Tools (Functions)

4 files changed, 136 insertions, 19 deletions

diff --git a/spec/logic/cartridge/affixes_spec.rb b/spec/logic/cartridge/affixes_spec.rb
index 8f08e1d..7263008 100644
--- a/spec/logic/cartridge/affixes_spec.rb
+++ b/spec/logic/cartridge/affixes_spec.rb
@@ -6,7 +6,7 @@ require_relative '../../../logic/cartridge/affixes'
 
 RSpec.describe NanoBot::Logic::Cartridge::Affixes do
   context 'interfaces' do
-    let(:cartridge) { load_cartridge('affixes.yml') }
+    let(:cartridge) { load_symbolized('cartridges/affixes.yml') }
 
     it 'gets the expected affixes' do
       expect(described_class.get(cartridge, :repl, :input, :prefix)).to eq('E')
@@ -22,7 +22,7 @@ RSpec.describe NanoBot::Logic::Cartridge::Affixes do
   end
 
   context 'interfaces fallback' do
-    let(:cartridge) { load_cartridge('affixes.yml') }
+    let(:cartridge) { load_symbolized('cartridges/affixes.yml') }
 
     it 'gets the expected affixes' do
       cartridge[:interfaces][:repl][:input].delete(:prefix)
@@ -48,7 +48,7 @@ RSpec.describe NanoBot::Logic::Cartridge::Affixes do
   end
 
   context 'interfaces nil' do
-    let(:cartridge) { load_cartridge('affixes.yml') }
+    let(:cartridge) { load_symbolized('cartridges/affixes.yml') }
 
     it 'gets the expected affixes' do
       cartridge[:interfaces][:repl][:input][:prefix] = nil
diff --git a/spec/logic/cartridge/interaction_spec.rb b/spec/logic/cartridge/interaction_spec.rb
index 347ac45..f3ba46e 100644
--- a/spec/logic/cartridge/interaction_spec.rb
+++ b/spec/logic/cartridge/interaction_spec.rb
@@ -6,41 +6,41 @@ require_relative '../../../logic/cartridge/interaction'
 
 RSpec.describe NanoBot::Logic::Cartridge::Interaction do
   context 'input' do
-    let(:cartridge) { load_cartridge('affixes.yml') }
+    let(:cartridge) { load_symbolized('cartridges/affixes.yml') }
 
     it 'prepares the input' do
       expect(described_class.input(cartridge, :repl, 'hello')).to eq(
-        { content: 'hello', fennel: nil, lua: nil, prefix: 'E', suffix: 'F' }
+        { content: 'hello', fennel: nil, lua: nil, clojure: nil, prefix: 'E', suffix: 'F' }
       )
 
       expect(described_class.input({}, :repl, 'hello')).to eq(
-        { content: 'hello', fennel: nil, lua: nil, prefix: nil, suffix: nil }
+        { content: 'hello', fennel: nil, lua: nil, clojure: nil, prefix: nil, suffix: nil }
       )
 
       expect(described_class.input(cartridge, :eval, 'hello')).to eq(
-        { content: 'hello', fennel: nil, lua: nil, prefix: 'I', suffix: 'J' }
+        { content: 'hello', fennel: nil, lua: nil, clojure: nil, prefix: 'I', suffix: 'J' }
       )
 
       expect(described_class.input({}, :eval, 'hello')).to eq(
-        { content: 'hello', fennel: nil, lua: nil, prefix: nil, suffix: nil }
+        { content: 'hello', fennel: nil, lua: nil, clojure: nil, prefix: nil, suffix: nil }
       )
     end
 
     it 'prepares the non-streamming output' do
       expect(described_class.output(cartridge, :repl, { message: 'hello' }, false, true)).to eq(
-        { message: { content: 'hello', fennel: nil, lua: nil } }
+        { message: { content: 'hello', fennel: nil, lua: nil, clojure: nil } }
       )
 
       expect(described_class.output({}, :repl, { message: 'hello' }, false, true)).to eq(
-        { message: { content: 'hello', fennel: nil, lua: nil } }
+        { message: { content: 'hello', fennel: nil, lua: nil, clojure: nil } }
       )
 
       expect(described_class.output(cartridge, :eval, { message: 'hello' }, false, true)).to eq(
-        { message: { content: 'hello', fennel: nil, lua: nil } }
+        { message: { content: 'hello', fennel: nil, lua: nil, clojure: nil } }
       )
 
       expect(described_class.output({}, :eval, { message: 'hello' }, false, true)).to eq(
-        { message: { content: 'hello', fennel: nil, lua: nil } }
+        { message: { content: 'hello', fennel: nil, lua: nil, clojure: nil } }
       )
     end
   end
diff --git a/spec/logic/cartridge/streaming_spec.rb b/spec/logic/cartridge/streaming_spec.rb
index e5ad012..466dd0b 100644
--- a/spec/logic/cartridge/streaming_spec.rb
+++ b/spec/logic/cartridge/streaming_spec.rb
@@ -5,8 +5,28 @@ require 'yaml'
 require_relative '../../../logic/cartridge/streaming'
 
 RSpec.describe NanoBot::Logic::Cartridge::Streaming do
+  context 'interfaces override' do
+    context 'defaults' do
+      let(:cartridge) { {} }
+
+      it 'uses default values when appropriate' do
+        expect(described_class.enabled?(cartridge, :repl)).to be(true)
+        expect(described_class.enabled?(cartridge, :eval)).to be(true)
+      end
+    end
+
+    context 'top-level overrides' do
+      let(:cartridge) { { interfaces: { output: { stream: false } } } }
+
+      it 'overrides default values when appropriate' do
+        expect(described_class.enabled?(cartridge, :repl)).to be(false)
+        expect(described_class.enabled?(cartridge, :eval)).to be(false)
+      end
+    end
+  end
+
   context 'provider' do
-    let(:cartridge) { load_cartridge('streaming.yml') }
+    let(:cartridge) { load_symbolized('cartridges/streaming.yml') }
 
     it 'checks if stream is enabled' do
       cartridge[:provider][:settings][:stream] = false
@@ -15,7 +35,7 @@ RSpec.describe NanoBot::Logic::Cartridge::Streaming do
   end
 
   context 'repl' do
-    let(:cartridge) { load_cartridge('streaming.yml') }
+    let(:cartridge) { load_symbolized('cartridges/streaming.yml') }
 
     it 'checks if stream is enabled' do
       cartridge[:interfaces][:repl][:output][:stream] = false
@@ -24,7 +44,7 @@ RSpec.describe NanoBot::Logic::Cartridge::Streaming do
   end
 
   context 'interface + repl' do
-    let(:cartridge) { load_cartridge('streaming.yml') }
+    let(:cartridge) { load_symbolized('cartridges/streaming.yml') }
 
     it 'checks if stream is enabled' do
       cartridge[:interfaces][:output][:stream] = false
@@ -34,7 +54,7 @@ RSpec.describe NanoBot::Logic::Cartridge::Streaming do
   end
 
   context 'interface' do
-    let(:cartridge) { load_cartridge('streaming.yml') }
+    let(:cartridge) { load_symbolized('cartridges/streaming.yml') }
 
     it 'checks if stream is enabled' do
       cartridge[:interfaces][:output][:stream] = false
@@ -44,7 +64,7 @@ RSpec.describe NanoBot::Logic::Cartridge::Streaming do
   end
 
   context '- repl' do
-    let(:cartridge) { load_cartridge('streaming.yml') }
+    let(:cartridge) { load_symbolized('cartridges/streaming.yml') }
 
     it 'checks if stream is enabled' do
       cartridge[:interfaces][:repl][:output].delete(:stream)
@@ -53,7 +73,7 @@ RSpec.describe NanoBot::Logic::Cartridge::Streaming do
   end
 
   context '- interface' do
-    let(:cartridge) { load_cartridge('streaming.yml') }
+    let(:cartridge) { load_symbolized('cartridges/streaming.yml') }
 
     it 'checks if stream is enabled' do
       cartridge[:interfaces][:output].delete(:stream)
@@ -63,7 +83,7 @@ RSpec.describe NanoBot::Logic::Cartridge::Streaming do
   end
 
   context '- provider' do
-    let(:cartridge) { load_cartridge('streaming.yml') }
+    let(:cartridge) { load_symbolized('cartridges/streaming.yml') }
 
     it 'checks if stream is enabled' do
       cartridge[:provider][:settings].delete(:stream)
diff --git a/spec/logic/cartridge/tools_spec.rb b/spec/logic/cartridge/tools_spec.rb
new file mode 100644
index 0000000..d08817c
--- /dev/null
+++ b/spec/logic/cartridge/tools_spec.rb
@@ -0,0 +1,97 @@
+# frozen_string_literal: true
+
+require 'yaml'
+
+require_relative '../../../logic/cartridge/tools'
+
+RSpec.describe NanoBot::Logic::Cartridge::Tools do
+  context 'interfaces override' do
+    context 'defaults' do
+      let(:cartridge) { {} }
+
+      it 'uses default values when appropriate' do
+        expect(described_class.feedback?(cartridge, :repl, :executing)).to be(false)
+        expect(described_class.feedback?(cartridge, :eval, :executing)).to be(false)
+
+        expect(described_class.feedback?(cartridge, :repl, :responding)).to be(true)
+        expect(described_class.feedback?(cartridge, :eval, :responding)).to be(true)
+      end
+    end
+
+    context 'top-level overrides' do
+      let(:cartridge) do
+        { interfaces: { tools: { feedback: false } } }
+      end
+
+      it 'overrides default values when appropriate' do
+        expect(described_class.feedback?(cartridge, :repl, :executing)).to be(false)
+        expect(described_class.feedback?(cartridge, :eval, :executing)).to be(false)
+
+        expect(described_class.feedback?(cartridge, :repl, :responding)).to be(false)
+        expect(described_class.feedback?(cartridge, :eval, :responding)).to be(false)
+      end
+    end
+
+    context 'top-level overrides' do
+      let(:cartridge) do
+        { interfaces: { tools: { feedback: true } } }
+      end
+
+      it 'overrides default values when appropriate' do
+        expect(described_class.feedback?(cartridge, :repl, :executing)).to be(true)
+        expect(described_class.feedback?(cartridge, :eval, :executing)).to be(true)
+
+        expect(described_class.feedback?(cartridge, :repl, :responding)).to be(true)
+        expect(described_class.feedback?(cartridge, :eval, :responding)).to be(true)
+      end
+    end
+
+    context 'top-level-specific overrides' do
+      let(:cartridge) do
+        { interfaces: { tools: { executing: { feedback: false }, responding: { feedback: true } } } }
+      end
+
+      it 'overrides default values when appropriate' do
+        expect(described_class.feedback?(cartridge, :repl, :executing)).to be(false)
+        expect(described_class.feedback?(cartridge, :eval, :executing)).to be(false)
+
+        expect(described_class.feedback?(cartridge, :repl, :responding)).to be(true)
+        expect(described_class.feedback?(cartridge, :eval, :responding)).to be(true)
+      end
+    end
+
+    context 'repl interface overrides' do
+      let(:cartridge) do
+        { interfaces: {
+          tools: { executing: { feedback: false }, responding: { feedback: true } },
+          repl: { tools: { executing: { feedback: true }, responding: { feedback: false } } }
+        } }
+      end
+
+      it 'overrides default values when appropriate' do
+        expect(described_class.feedback?(cartridge, :repl, :executing)).to be(true)
+        expect(described_class.feedback?(cartridge, :eval, :executing)).to be(false)
+
+        expect(described_class.feedback?(cartridge, :repl, :responding)).to be(false)
+        expect(described_class.feedback?(cartridge, :eval, :responding)).to be(true)
+      end
+    end
+
+    context 'eval interface overrides' do
+      let(:cartridge) do
+        { interfaces: {
+          tools: { executing: { feedback: false }, responding: { feedback: true } },
+          eval: { tools: { executing: { feedback: true }, responding: { feedback: false } } }
+        } }
+      end
+
+      it 'overrides default values when appropriate' do
+        expect(described_class.feedback?(cartridge, :repl, :executing)).to be(false)
+        expect(described_class.feedback?(cartridge, :eval, :executing)).to be(true)
+
+        expect(described_class.feedback?(cartridge, :repl, :responding)).to be(true)
+        expect(described_class.feedback?(cartridge, :eval, :responding)).to be(false)
+      end
+    end
+  end
+end